xfs
[Top] [All Lists]

Re: [PATCH] mm/vmscan: Do not block forever atshrink_inactive_list().

To: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] mm/vmscan: Do not block forever atshrink_inactive_list().
From: David Rientjes <rientjes@xxxxxxxxxx>
Date: Tue, 3 Jun 2014 14:43:22 -0700 (PDT)
Cc: Motohiro.Kosaki@xxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, riel@xxxxxxxxxx, kosaki.motohiro@xxxxxxxxxxxxxx, fengguang.wu@xxxxxxxxx, kamezawa.hiroyu@xxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version:content-type; bh=55XL2FyS/3CnWBbS19BbAcN0SP0TlWG96DuZ8t0FVzQ=; b=ZbKJmFRaiBNnZF3x5JoC2sX0uUVsxNdHNh7/RiKAkSGBQo21+3LKyduwM1QzhRBAHx D2qrOg0nH2ld0EZ9mM6xhMg8AJj9lGYATfVnURkRCTo9l+agHLWJQXkhaOYZVC8TgNZG 67d62+3Oc2m19HyrP5Wc9MwALc4IL6MSh3xDrU9q5fcMvo34+kJWkt7ubi1GUm3Om0xv kvmi3EH+S5KCU/W0QULcrkaCY9ehpdexWWzzYGRJbzzQ878C31ZZFCTgHFUTmrYFoGw5 Mm73Cc7963o7U/57rG/rA6HOVKZXj0WWDC5xwG1U0mpxe9buzxyHaSGd5vWcFojmpCRp sz0A==
In-reply-to: <201405262045.CDG95893.HLFFOSFMQOVOJt@xxxxxxxxxxxxxxxxxxx>
References: <20140520004449.GE18954@dastard> <20140519225915.3370328d.akpm@xxxxxxxxxxxxxxxxxxxx> <20140520063024.GH18954@dastard> <201405202358.ADF10119.SMOFOQLFtOVHJF@xxxxxxxxxxxxxxxxxxx> <6B2BA408B38BA1478B473C31C3D2074E31D59D8673@xxxxxxxxxxxxxxxxxxxxxxxxxx> <201405262045.CDG95893.HLFFOSFMQOVOJt@xxxxxxxxxxxxxxxxxxx>
User-agent: Alpine 2.02 (DEB 1266 2009-07-14)
On Mon, 26 May 2014, Tetsuo Handa wrote:

> In shrink_inactive_list(), we do not insert delay at
> 
>   if (!sc->hibernation_mode && !current_is_kswapd())
>     wait_iff_congested(zone, BLK_RW_ASYNC, HZ/10);
> 
> if sc->hibernation_mode != 0.
> Follow the same reason, we should not insert delay at
> 
>   while (unlikely(too_many_isolated(zone, file, sc))) {
>     congestion_wait(BLK_RW_ASYNC, HZ/10);
> 
>     /* We are about to die and free our memory. Return now. */
>     if (fatal_signal_pending(current))
>       return SWAP_CLUSTER_MAX;
>   }
> 
> if sc->hibernation_mode != 0.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> ---
>  mm/vmscan.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 32c661d..89c42ca 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1362,6 +1362,9 @@ static int too_many_isolated(struct zone *zone, int 
> file,
>       if (current_is_kswapd())
>               return 0;
>  
> +     if (sc->hibernation_mode)
> +             return 0;
> +
>       if (!global_reclaim(sc))
>               return 0;
>  

This isn't the only too_many_isolated() functions that do a delay, how is 
the too_many_isolated() in mm/compaction.c different?

<Prev in Thread] Current Thread [Next in Thread>