| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsprogs: xfs_copy: fix data corruption of target |
| From: | Junxiao Bi <junxiao.bi@xxxxxxxxxx> |
| Date: | Thu, 29 May 2014 09:46:17 +0800 |
| Cc: | xfs@xxxxxxxxxxx, joe.jin@xxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140528053241.GC3816@xxxxxxxxxxxxx> |
| References: | <1401247687-6444-1-git-send-email-junxiao.bi@xxxxxxxxxx> <20140528053241.GC3816@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/28/2014 01:32 PM, Christoph Hellwig wrote: > On Wed, May 28, 2014 at 11:28:07AM +0800, Junxiao Bi wrote: >> The unit of XFS_AGFL_DADDR(mp) is "basic block" whose size is "BBSIZE" >> (512 bytes), so when "source_sectorsize" is not 512, it will cause the >> target a corrupted filesystem. >> >> Signed-off-by: Junxiao Bi <junxiao.bi@xxxxxxxxxx> > Looks good. Any chance you could create a testcase for this as well? I will try. Thank you for review it. Thanks, Junxiao. > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | MONEY GRAM INTERNATIONAL, Money Gram International Money Transfer |
|---|---|
| Next by Date: | Re: xfs: possible deadlock warning, Gu Zheng |
| Previous by Thread: | Re: [PATCH] xfsprogs: xfs_copy: fix data corruption of target, Christoph Hellwig |
| Next by Thread: | xfs: possible deadlock warning, Gu Zheng |
| Indexes: | [Date] [Thread] [Top] [All Lists] |