| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 0/2, RFC] xfsprogs: try to handle mkfs of a file on 4k sector device |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Wed, 28 May 2014 08:50:14 -0500 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140528054142.GC13166@xxxxxxxxxxxxx> |
| References: | <53852A05.5040006@xxxxxxxxxx> <20140528054142.GC13166@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 5/28/14, 12:41 AM, Christoph Hellwig wrote: >> We can modify platform_findsizes() to use the fsgeom call to get the >> "sector size" which should be used here, and warn that mismatches >> might exist if it fails. >> >> This does mean there'll be a new warning emitted on fs images hosted >> on non-xfs filesystems; I'm not really quite sure it's worth it, >> hence the RFC nature of this lightly tested 2-patch series... > > Might be time to introduce some generic VFS-level ioctl for the sector > size and dio alignment. Any beer or chocolate that could motivate you > to get this done? :) Roses from you, Christoph. ;) Yeah, we do desperately need this. Not sure why nobody's done it yet, I'll see if I can get the time & motivation going, and launch into the bike shed building. :) > Also it would be nice to have a test case that exercises this new code. Hm yeah fair enough; I tested it w/ scsi-debug... -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2 2/3] xfs: run an eofblocks scan on ENOSPC/EDQUOT, Brian Foster |
|---|---|
| Next by Date: | Re: [PATCH v2 1/3] xfs: add scan owner field to xfs_eofblocks, Brian Foster |
| Previous by Thread: | Re: [PATCH 0/2, RFC] xfsprogs: try to handle mkfs of a file on 4k sector device, Christoph Hellwig |
| Next by Thread: | [PATCH] xfsprogs: xfs_copy: fix data corruption of target, Junxiao Bi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |