xfs
[Top] [All Lists]

Re: [PATCH 0/2, RFC] xfsprogs: try to handle mkfs of a file on 4k sector

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 0/2, RFC] xfsprogs: try to handle mkfs of a file on 4k sector device
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 27 May 2014 22:41:42 -0700
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53852A05.5040006@xxxxxxxxxx>
References: <53852A05.5040006@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> We can modify platform_findsizes() to use the fsgeom call to get the
> "sector size" which should be used here, and warn that mismatches
> might exist if it fails.
> 
> This does mean there'll be a new warning emitted on fs images hosted
> on non-xfs filesystems; I'm not really quite sure it's worth it,
> hence the RFC nature of this lightly tested 2-patch series...

Might be time to introduce some generic VFS-level ioctl for the sector
size and dio alignment.  Any beer or chocolate that could motivate you
to get this done? :)

Also it would be nice to have a test case that exercises this new code.

<Prev in Thread] Current Thread [Next in Thread>