xfs
[Top] [All Lists]

Re: [PATCH 1/2, RFC] xfsprogs: check fs sector size in platform_findsize

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/2, RFC] xfsprogs: check fs sector size in platform_findsizes()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 27 May 2014 22:39:12 -0700
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53852A61.90400@xxxxxxxxxxx>
References: <53852A05.5040006@xxxxxxxxxx> <53852A61.90400@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 27, 2014 at 07:14:25PM -0500, Eric Sandeen wrote:
> Try the xfs geometry ioctl if the mkfs target resides
> in a file; this gives us the equivalent of a device
> sector size.
> 
> This does, however, emit a warning if the target file
> exists on a non-XFS filesystem, and that might not be super.

You could simple not print the warning in case this bothers you..

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>