Re: [PATCH 1/2, RFC] xfsprogs: check fs sector size in platform_findsizes()

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Tue, May 27, 2014 at 07:14:25PM -0500, Eric Sandeen wrote:
> Try the xfs geometry ioctl if the mkfs target resides
> in a file; this gives us the equivalent of a device
> sector size.
> 
> This does, however, emit a warning if the target file
> exists on a non-XFS filesystem, and that might not be super.

You could simple not print the warning in case this bothers you..

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>