| To: | Junxiao Bi <junxiao.bi@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsprogs: xfs_copy: fix data corruption of target |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 27 May 2014 22:32:41 -0700 |
| Cc: | xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx, joe.jin@xxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1401247687-6444-1-git-send-email-junxiao.bi@xxxxxxxxxx> |
| References: | <1401247687-6444-1-git-send-email-junxiao.bi@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, May 28, 2014 at 11:28:07AM +0800, Junxiao Bi wrote: > The unit of XFS_AGFL_DADDR(mp) is "basic block" whose size is "BBSIZE" > (512 bytes), so when "source_sectorsize" is not 512, it will cause the > target a corrupted filesystem. > > Signed-off-by: Junxiao Bi <junxiao.bi@xxxxxxxxxx> Looks good. Any chance you could create a testcase for this as well? Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2 1/3] xfs: add scan owner field to xfs_eofblocks, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 1/2, RFC] xfsprogs: check fs sector size in platform_findsizes(), Christoph Hellwig |
| Previous by Thread: | [PATCH] xfsprogs: xfs_copy: fix data corruption of target, Junxiao Bi |
| Next by Thread: | Re: [PATCH] xfsprogs: xfs_copy: fix data corruption of target, Junxiao Bi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |