| To: | Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH 2/2, RFC] mkfs.xfs: don't call blkid_get_topology on regular files |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Tue, 27 May 2014 19:15:20 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <53852A05.5040006@xxxxxxxxxx> |
| References: | <53852A05.5040006@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
If we encounter a target that's really a regular file,
even without "-d file..." on the cmdline, call
platform_findsizes() instead of blkid_get_topology to
try to discover the "sector size" via the fsgeom() call.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 37c05a9..74180c9 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -454,12 +454,26 @@ static void get_topology(
struct fs_topology *ft,
int force_overwrite)
{
- if (!xi->disfile) {
- const char *dfile = xi->volname ? xi->volname : xi->dname;
+ int is_a_file = 0;
+ struct stat statbuf;
+ char *dfile = xi->volname ? xi->volname : xi->dname;
+ if (!stat(dfile, &statbuf) && S_ISREG(statbuf.st_mode))
+ is_a_file = 1;
+
+ if (!xi->disfile && !is_a_file) {
blkid_get_topology(dfile, &ft->dsunit, &ft->dswidth,
&ft->lsectorsize, &ft->psectorsize,
force_overwrite);
+ } else {
+ int fd;
+ long long dummy;
+
+ fd = open(dfile, O_RDONLY);
+ if (fd >= 0) {
+ platform_findsizes(dfile, fd, &dummy, &ft->lsectorsize);
+ close(fd);
+ }
}
if (xi->rtname && !xi->risfile) {
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/2, RFC] xfsprogs: check fs sector size in platform_findsizes(), Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH v2 2/7] xfs: add support FALLOC_FL_COLLAPSE_RANGE for fallocate, Dave Chinner |
| Previous by Thread: | Re: [PATCH 1/2, RFC] xfsprogs: check fs sector size in platform_findsizes(), Christoph Hellwig |
| Next by Thread: | Re: [PATCH 2/2, RFC] mkfs.xfs: don't call blkid_get_topology on regular files, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |