xfs
[Top] [All Lists]

Re: [PATCH 11/16] xfs: move node entry counts to xfs_da_geometry

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 11/16] xfs: move node entry counts to xfs_da_geometry
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 28 May 2014 09:47:21 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140527155941.GC11265@xxxxxxxxxxxxxx>
References: <1400803432-20048-1-git-send-email-david@xxxxxxxxxxxxx> <1400803432-20048-12-git-send-email-david@xxxxxxxxxxxxx> <20140527155941.GC11265@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 27, 2014 at 11:59:41AM -0400, Brian Foster wrote:
> On Fri, May 23, 2014 at 10:03:47AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > ---
> 
> Are the state->blocksize and node_ents fields redundant with the
> associated geo fields? On a quick scan, it seems like they don't ever
> change. Patch looks fine either way...

Until the conversion of the args structure is complete they aren't
redundant. I can probably add a patch to the end removing them,
though...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>