xfs
[Top] [All Lists]

Re: [PATCH v2 1/3] xfs: add scan owner field to xfs_eofblocks

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v2 1/3] xfs: add scan owner field to xfs_eofblocks
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 27 May 2014 03:44:28 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1400845950-41435-2-git-send-email-bfoster@xxxxxxxxxx>
References: <1400845950-41435-1-git-send-email-bfoster@xxxxxxxxxx> <1400845950-41435-2-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, May 23, 2014 at 07:52:28AM -0400, Brian Foster wrote:
> The scan owner field represents an optional inode number that is
> responsible for the current scan. The purpose is to identify that an
> inode is under iolock and as such, the iolock shouldn't be attempted
> when trimming eofblocks. This is an internal only field.

xfs_free_eofblocks already does a trylock, and without that calling it
from one iolock holding process to another would be a deadlock waiting
to happen.

I have to say I'm still not very easy with iolock nesting, even if it's
a trylock.

<Prev in Thread] Current Thread [Next in Thread>