xfs
[Top] [All Lists]

Re: [PATCH v2 3/3] xfs: squash prealloc while over quota free space as w

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v2 3/3] xfs: squash prealloc while over quota free space as well
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 27 May 2014 09:00:59 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1400845950-41435-4-git-send-email-bfoster@xxxxxxxxxx>
References: <1400845950-41435-1-git-send-email-bfoster@xxxxxxxxxx> <1400845950-41435-4-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, May 23, 2014 at 07:52:30AM -0400, Brian Foster wrote:
> Commit 4d559a3b introduced heavy prealloc. squashing to catch the case
> of requesting too large a prealloc on smaller filesystems, leading to
> repeated flush and retry cycles that occur on ENOSPC. Now that we issue
> eofblocks scans on EDQUOT/ENOSPC, squash the prealloc against the
> minimum available free space across all applicable quotas as well to
> avoid a similar problem of repeated eofblocks scans.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Good idea - thrashing is something worth avoiding....

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>