xfs
[Top] [All Lists]

Re: [PATCH] do_mounts: try all available filesystems before panicking

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] do_mounts: try all available filesystems before panicking
From: ÐÐÐÐÐÐ ÐÐÑÑÐÐ <plamen.sisi@xxxxxxxxx>
Date: Mon, 26 May 2014 08:18:59 +0300
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=XJfnc0EwjwYC+eKxd7oeVEQWqtDVKx7k75c8lVM1R+M=; b=QE4TyNnL+k3LaDWN8XWL542RxcNBbsKpVol7jECPUBMbht2C/TLjnpHHkJo6JLvY6K SCwanSBhTLQwG1/UowjAPC6n1/a1FWtyqPv4S5WFlWu+zT9COTBWiQsexcIJW81OIXXY EARaephb98FdNfTaIkJagvQ3r3GeML0johQJYks8wZwoqmgdIRglS7mHe9Vjhww5W2el CdjRmR2jQDGMZx9s7Li010DPRXn32wvbBUvR1R8JymGwRHJd9MP/KyoxeGB+2/M76RVZ ohH/CE4srF11hu/I4VtMOLjCcD322WhhOr9wfsqu45O6ke/0SrcKKjVlWmCfMxfdeX68 hwKA==
In-reply-to: <20140526041958.GV8554@dastard>
References: <1399314889-9829-1-git-send-email-plamen.sisi@xxxxxxxxx> <CA+55aFwxF2xnYerLdJZ2gQdZizK3953L16X5KkUAqD-YePausQ@xxxxxxxxxxxxxx> <20140526000813.GS8554@dastard> <20140526011904.GT8554@dastard> <20140526041958.GV8554@dastard>
2014-05-26 7:19 GMT+03:00 Dave Chinner <david@xxxxxxxxxxxxx>:
> On Mon, May 26, 2014 at 11:19:04AM +1000, Dave Chinner wrote:
>> On Mon, May 26, 2014 at 10:08:13AM +1000, Dave Chinner wrote:
>> > On Sun, May 25, 2014 at 01:04:09PM -0700, Linus Torvalds wrote:
>> > > On Mon, May 5, 2014 at 11:34 AM, Plamen Petrov <plamen.sisi@xxxxxxxxx> 
>> > > wrote:
>> > > >
>> > > > The story short: on systems with btrfs root I have a kernel .config 
>> > > > with ext4,
>> > > > xfs and btrfs built-in which works fine with 3.13.x, but 3.14.x 
>> > > > panics. After
>> > > > inserting some debug printks, I got this info from mount_block_root:
>> > > >
>> > > > ---> EACCESS=13, EINVAL=22, Available filesystems: ext3 ext2 ext4 
>> > > > fuseblk xfs btrfs
>> > > > -----> Tried ext3, error code is -22.
>> > > > -----> Tried ext2, error code is -22.
>> > > > -----> Tried ext4, error code is -22.
>> > > > -----> Tried fuseblk, error code is -22.
>> > > > -----> Tried xfs, error code is -38.
>> > > > VFS: Cannot open root device "sda2" or unknown-block(8,2): error -38
>> > > > Please append a correct "root=" boot option; here are the available 
>> > > > partitions:
>>
>> BTW, This is the original thread with lots of triage in it:
>>
>> http://www.spinics.net/lists/linux-btrfs/msg33455.html
>>
>> But that doesn't reach any conclusion. I suspect that the
>> change of btrfs init (from very early (@~1.8s into the boot) until a
>> few milliseconds before the root mount is changing the order in
>> which the filesystem type list is traversed by the mount, resulting
>> in XFS being used to probe the device before btrfs.
>
> On that point, on 3.15-rc6:
>
> $ tail -1 /proc/filesystems
>         btrfs
> $
>
>> Why XFS is seeing /dev/sda2 as containing an XFS filesystem is not
>> yet clear, but perhaps once you've dumped the the first sector of
>> the btrfs partition all will become clear....
>
> No need, I found the regression. Plamen, can you please try the
> patch below?
>

Yes, Dave. I applied your patch on top of linux 3.15-rc5. I tried the patch
you sent in a VM I used for tests.

With only your patch applied - the system boots up normally.

Thanks for the different perspectives, guys! Always a pleasure
communicating with you. After a month or so waiting - definetly worth it!

Thanks a lot!
-- 
Plamen Petrov

<Prev in Thread] Current Thread [Next in Thread>