xfs
[Top] [All Lists]

Re: [PATCH] do_mounts: try all available filesystems before panicking

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] do_mounts: try all available filesystems before panicking
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Sun, 25 May 2014 17:11:30 -0400
Cc: Plamen Petrov <plamen.sisi@xxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, sandeen@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=JPJyOGD6G3iXb/SIxyLfK+LXamY/bpihA4trDStpERo=; b=hlSuaPyZkqspdGyvhyb0o/bbLgb4fkkYbNomDdQQao/RsqdMeFN2XT8bxOJZDQboqkurtIBLp8fv8tTGvrm7VUNfCfU7k83ZqeN1f0EZZWlOFvxNP0HTvxT2jMhAbcxEoK5bfaE0nXaQs1rBON9akDK0vWL3U5tAvrLwL9oGaTw=;
In-reply-to: <CA+55aFwxF2xnYerLdJZ2gQdZizK3953L16X5KkUAqD-YePausQ@xxxxxxxxxxxxxx>
Mail-followup-to: Theodore Ts'o <tytso@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Plamen Petrov <plamen.sisi@xxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, sandeen@xxxxxxxxxx
References: <1399314889-9829-1-git-send-email-plamen.sisi@xxxxxxxxx> <CA+55aFwxF2xnYerLdJZ2gQdZizK3953L16X5KkUAqD-YePausQ@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Sun, May 25, 2014 at 01:04:09PM -0700, Linus Torvalds wrote:
> 
> The fact is, I think xfs is just buggy. Returning 38 (ENOSYS) is
> totally insane. "No such system call"? Somebody is on some bad bad
> drugs. Not that the mount_block_root() loop and error handling might
> not be a good thing to perhaps tweak _too_, but at the very least your
> patch means that now it no longer prints out the error number at all.

There's only a single instance of ENOSYS in fs/xfs/xfs_mount.c:

        /*
         * We must be able to do sector-sized and sector-aligned IO.
         */
        if (sector_size > sbp->sb_sectsize) {
                if (loud)
                        xfs_warn(mp, "device supports %u byte sectors (not %u)",
                                sector_size, sbp->sb_sectsize);
                error = ENOSYS;
                goto release_buf;
        }

Plamen, does changing the ENOSYS to EINVAL above fix things for you?

> Anyway, I'm also not seeing why that xfs error would be new to 3.14,
> though.. Adding the XFS people to the cc.

If I had to guess, commit daba5427d is new to 3.14, and it might
explain the change in behavior.

Cheers,

                                                - Ted

<Prev in Thread] Current Thread [Next in Thread>