[Top] [All Lists]

Re: [PATCH] xfs/005: filter _scratch_mount output and fix golden output

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH] xfs/005: filter _scratch_mount output and fix golden output to match it
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 23 May 2014 09:34:49 +1000
Cc: fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1400775429-30015-1-git-send-email-eguan@xxxxxxxxxx>
References: <1400775429-30015-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, May 23, 2014 at 12:17:09AM +0800, Eryu Guan wrote:
> Failure message of _scratch_mount is something like:
> mount: mount /dev/sda5 on /mnt/scratch failed: Structure needs cleaning
> not
> mount: Structure needs cleaning

Evidence to the contrary:

# MKFS_OPTIONS="-b size=1024 -m crc=1"  ./check xfs/005
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 test1 3.15.0-rc5-dgc+
MKFS_OPTIONS  -- -f -b size=1024 -m crc=1 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/scratch

xfs/005 0s ... 0s
Ran: xfs/005
Passed all 1 tests

# mount /dev/vdb /mnt/scratch
mount: Structure needs cleaning
# mount -V
mount from util-linux 2.20.1 (with libblkid and selinux support)

So xfs/005 is correct for a relatively recent mount binary.
What version of mount are you using?


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>