xfs
[Top] [All Lists]

[patch v2] [XFS] small cleanup in xfs_lowbit64()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: [patch v2] [XFS] small cleanup in xfs_lowbit64()
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 22 May 2014 17:04:05 +0300
Cc: xfs@xxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140521142909.GA22281@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
There are two checkpatch.pl complaints here because of the bad indenting
and because of the assignment inside the condition.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
v2: more cleanups

diff --git a/fs/xfs/xfs_bit.h b/fs/xfs/xfs_bit.h
index f1e3c90..e1649c0 100644
--- a/fs/xfs/xfs_bit.h
+++ b/fs/xfs/xfs_bit.h
@@ -66,8 +66,11 @@ static inline int xfs_lowbit64(__uint64_t v)
                n = ffs(w);
        } else {        /* upper bits */
                w = (__uint32_t)(v >> 32);
-               if (w && (n = ffs(w)))
-               n += 32;
+               if (w) {
+                       n = ffs(w);
+                       if (n)
+                               n += 32;
+               }
        }
        return n - 1;
 }

<Prev in Thread] Current Thread [Next in Thread>