xfs
[Top] [All Lists]

Re: [patch] [XFS] indent an if statement

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [patch] [XFS] indent an if statement
From: walter harms <wharms@xxxxxx>
Date: Wed, 21 May 2014 18:50:53 +0200
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140521143550.GC15585@mwanda>
References: <20140521122746.GD23396@mwanda> <20140521142909.GA22281@xxxxxxxxxxxxx> <20140521143550.GC15585@mwanda>
Reply-to: wharms@xxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11

Am 21.05.2014 16:35, schrieb Dan Carpenter:
> On Wed, May 21, 2014 at 07:29:09AM -0700, Christoph Hellwig wrote:
>> On Wed, May 21, 2014 at 03:27:46PM +0300, Dan Carpenter wrote:
>>> The "n += 32;" goes with the if statement on the line before so it
>>> should be indented.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>>>
>>> diff --git a/fs/xfs/xfs_bit.h b/fs/xfs/xfs_bit.h
>>> index f1e3c90..f685942 100644
>>> --- a/fs/xfs/xfs_bit.h
>>> +++ b/fs/xfs/xfs_bit.h
>>> @@ -67,7 +67,7 @@ static inline int xfs_lowbit64(__uint64_t v)
>>>     } else {        /* upper bits */
>>>             w = (__uint32_t)(v >> 32);
>>>             if (w && (n = ffs(w)))
>>> -           n += 32;
>>> +                   n += 32;
>>
>> If we want to clean up this stuff let's do it properly:
>>
>>              if (w) {
>>                      n = ffs(w);
>>                      if (n)
>>                              n += 32;
>>              }
>>
> 


This looks like a ffsll() maybe there are other implemantions and we can
make a generic version (acualy i found only a ffsll() in nouvou, NTL).

just my 2 cents,

re,
 wh


> Sure.  I will resend.
> 
> regards,
> dan carpenter
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

<Prev in Thread] Current Thread [Next in Thread>