xfs
[Top] [All Lists]

Re: [patch] [XFS] indent an if statement

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [patch] [XFS] indent an if statement
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 21 May 2014 07:44:08 -0500
Cc: kernel-janitors@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140521122746.GD23396@mwanda>
References: <20140521122746.GD23396@mwanda>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
On 5/21/14, 7:27 AM, Dan Carpenter wrote:
> The "n += 32;" goes with the if statement on the line before so it
> should be indented.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Easy one ;)

Wow, it's been this way ever since 79071eb0 in 2008.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> diff --git a/fs/xfs/xfs_bit.h b/fs/xfs/xfs_bit.h
> index f1e3c90..f685942 100644
> --- a/fs/xfs/xfs_bit.h
> +++ b/fs/xfs/xfs_bit.h
> @@ -67,7 +67,7 @@ static inline int xfs_lowbit64(__uint64_t v)
>       } else {        /* upper bits */
>               w = (__uint32_t)(v >> 32);
>               if (w && (n = ffs(w)))
> -             n += 32;
> +                     n += 32;
>       }
>       return n - 1;
>  }
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>