xfs
[Top] [All Lists]

Re: [PATCH 0/5] xfstests: fixes for the free inode btree

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 0/5] xfstests: fixes for the free inode btree
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 21 May 2014 10:20:37 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140505113443.GA11622@xxxxxxxxxxxxxx>
References: <1399050842-19633-1-git-send-email-bfoster@xxxxxxxxxx> <20140502234831.GG26353@dastard> <20140505113443.GA11622@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, May 05, 2014 at 07:34:43AM -0400, Brian Foster wrote:
> On Sat, May 03, 2014 at 09:48:31AM +1000, Dave Chinner wrote:
> > On Fri, May 02, 2014 at 01:13:57PM -0400, Brian Foster wrote:
> > > Hi all,
> > > 
> > > This series is a few xfstests fixes and addons for the finobt. Patch 1
> > > fixes xfs/030 to work correctly on finobt-enabled filesystems. Patches 2
> > > and 3 add support for finobt-oriented tests via require functions and
> > > repair filter updates. Patch 4 adds a new test for targeted repair of
> > > finobt filesystems. Patch 5 adds a stress test that creates/modifies a
> > > sparsely allocated set of inodes to effectively exercise the finobt in
> > > conjunction with an fsstress workload.
> > > 
> > > xfs/010 runs very quickly. xfs/013 runs for 5-10 minutes on my smallish
> > > VM running against a single spindle, so I've been back and forth on
> > > whether it should be part of the auto group. Thoughts, reviews, flames
> > > appreciated...
> > 
> > 5-10 minutes is probably right at the edge for auto, but I think
> > that most people won't be testing this any time soon. Hence I'd
> > include it by default in the auto group, and if people complain
> > about the runtime when they start testing it, we can revist that
> > choice. FWIW, I'd also include it in the metadata group so that it
> > gets exercised when people run that group....
> > 
> 
> Ok, sounds good. It actually runs closer to 5 minutes than 10 when I
> simply move to a separate (still single) spindle, so it's probably not
> that bad. IIRC, it's still probably not the longest running test I've
> seen in auto. I believe you have an SSD test setup, so I'm curious how
> the workload looks if you get a a chance to run it there. :)

FWIW, just running xfs/013 on 2 sata drives in hw RAID1 takes 80-90s
to run xfs/013, so this is fine. However, it runs out of disk space
on a 4GB ramdisk, so it still might need some tweaking...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>