| To: | Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] mm/vmscan: Do not block forever at shrink_inactive_list(). |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 20 May 2014 00:20:57 -0700 |
| Cc: | Dave Chinner <david@xxxxxxxxxxxxx>, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>, riel@xxxxxxxxxx, kosaki.motohiro@xxxxxxxxxxxxxx, fengguang.wu@xxxxxxxxx, kamezawa.hiroyu@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140519225915.3370328d.akpm@xxxxxxxxxxxxxxxxxxxx> |
| References: | <201405192340.FCD48964.OFQHOOJLVSFFMt@xxxxxxxxxxxxxxxxxxx> <20140520004449.GE18954@dastard> <20140519225915.3370328d.akpm@xxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, May 19, 2014 at 10:59:15PM -0700, Andrew Morton wrote: > So current_is_kswapd() returns true for a thread which is not kswapd. > That's a bit smelly. > > Should this thread really be incrementing KSWAPD_INODESTEAL instead of > PGINODESTEAL, for example? current_is_kswapd() does a range of things, > only one(?) of which you actually want. Actually we want all of them. The allocation workqueue is a workaround for the incredible stack usage in the Linux I/O path. If it is called by kswapd it should act as if it were kswapd for all purposes. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] mm/vmscan: Do not block forever at shrink_inactive_list()., Dave Chinner |
|---|---|
| Next by Date: | Re: [ANNOUNCE] xfsprogs: v3.2.0 released!, Dave Chinner |
| Previous by Thread: | Re: [PATCH] mm/vmscan: Do not block forever atshrink_inactive_list()., Tetsuo Handa |
| Next by Thread: | Processing of xfsprogs_3.2.0_i386.changes, Debian FTP Masters |
| Indexes: | [Date] [Thread] [Top] [All Lists] |