| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: remove redundant checks from xfs_da_read_buf |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 17 May 2014 04:54:50 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1400281288-30652-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1400281288-30652-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sat, May 17, 2014 at 09:01:28AM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > All of the verification checks of magic numbers are now done by > verifiers, so ther eis no need to check them again once the buffer > has been successfully read. If the magic number is bad, it won't > even get to that code to verify it so it really serves no purpose at > all anymore. Remove it. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/5] xfs: turn NLINK feature on by default, Christoph Hellwig |
|---|---|
| Next by Date: | Bug#748483: xfsprogs: Let's add a watch file, Vincent Blut |
| Previous by Thread: | [PATCH] xfs: remove redundant checks from xfs_da_read_buf, Dave Chinner |
| Next by Thread: | Bug#748483: xfsprogs: Let's add a watch file, Vincent Blut |
| Indexes: | [Date] [Thread] [Top] [All Lists] |