xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfs: turn NLINK feature on by default

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: turn NLINK feature on by default
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 17 May 2014 04:54:25 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1400281252-29638-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1400281252-29638-1-git-send-email-david@xxxxxxxxxxxxx> <1400281252-29638-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index 944f3d9..3f09782 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -697,6 +697,12 @@ xfs_mountfs(
>                       mp->m_update_flags |= XFS_SB_VERSIONNUM;
>       }
>  
> +     /* always use v2 inodes by default now */
> +     if (!(mp->m_sb.sb_versionnum & XFS_SB_VERSION_NLINKBIT)) {
> +             mp->m_sb.sb_versionnum |= XFS_SB_VERSION_NLINKBIT;
> +             mp->m_update_flags |= XFS_SB_VERSIONNUM;
> +     }

This probably should print a message for the user.

Otherwise looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>