xfs
[Top] [All Lists]

Re: [PATCH 6/9] xfs: fix wrong err sign on xfs_set_acl()

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 6/9] xfs: fix wrong err sign on xfs_set_acl()
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 13 May 2014 20:51:49 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1399971373-6242-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1399971373-6242-1-git-send-email-david@xxxxxxxxxxxxx> <1399971373-6242-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 05/13 2014 16:56 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_iops.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index adfb18e..36d6303 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -173,12 +173,12 @@ xfs_generic_create(
>  
>  #ifdef CONFIG_XFS_POSIX_ACL
>       if (default_acl) {
> -             error = xfs_set_acl(inode, default_acl, ACL_TYPE_DEFAULT);
> +             error = -xfs_set_acl(inode, default_acl, ACL_TYPE_DEFAULT);
>               if (error)
>                       goto out_cleanup_inode;
>       }
>       if (acl) {
> -             error = xfs_set_acl(inode, acl, ACL_TYPE_ACCESS);
> +             error = -xfs_set_acl(inode, acl, ACL_TYPE_ACCESS);
>               if (error)
>                       goto out_cleanup_inode;
>       }
> 

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Cheers,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>