xfs
[Top] [All Lists]

Re: [PATCH 5/9] xfs: fix wrong errno from xfs_initxattrs

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 5/9] xfs: fix wrong errno from xfs_initxattrs
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 13 May 2014 20:51:04 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1399971373-6242-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1399971373-6242-1-git-send-email-david@xxxxxxxxxxxxx> <1399971373-6242-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 05/13 2014 16:56 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_iops.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 301ecbf..adfb18e 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -72,8 +72,8 @@ xfs_initxattrs(
>       int                     error = 0;
>  
>       for (xattr = xattr_array; xattr->name != NULL; xattr++) {
> -             error = xfs_attr_set(ip, xattr->name, xattr->value,
> -                                  xattr->value_len, ATTR_SECURE);
> +             error = -xfs_attr_set(ip, xattr->name, xattr->value,
> +                                   xattr->value_len, ATTR_SECURE);
>               if (error < 0)
>                       break;
>       }
> @@ -93,8 +93,8 @@ xfs_init_security(
>       struct inode    *dir,
>       const struct qstr *qstr)
>  {
> -     return security_inode_init_security(inode, dir, qstr,
> -                                         &xfs_initxattrs, NULL);
> +     return -security_inode_init_security(inode, dir, qstr,
> +                                          &xfs_initxattrs, NULL);
>  }
>  
>  static void
> 

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Cheers,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>