xfs
[Top] [All Lists]

Re: [PATCH 4/9] xfs: correct error sign on COLLAPSE_RANGE errors

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 4/9] xfs: correct error sign on COLLAPSE_RANGE errors
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 13 May 2014 20:49:27 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1399971373-6242-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1399971373-6242-1-git-send-email-david@xxxxxxxxxxxxx> <1399971373-6242-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 05/13 2014 16:56 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 37f98c6..830c1c9 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -837,7 +837,7 @@ xfs_file_fallocate(
>               unsigned blksize_mask = (1 << inode->i_blkbits) - 1;
>  
>               if (offset & blksize_mask || len & blksize_mask) {
> -                     error = -EINVAL;
> +                     error = EINVAL;
>                       goto out_unlock;
>               }
>  
> @@ -846,7 +846,7 @@ xfs_file_fallocate(
>                * in which case it is effectively a truncate operation
>                */
>               if (offset + len >= i_size_read(inode)) {
> -                     error = -EINVAL;
> +                     error = EINVAL;
>                       goto out_unlock;
>               }
>  
> 

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>


Cheers,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>