xfs
[Top] [All Lists]

Re: [PATCH 2/9] xfs: fix incorrect error sign in xfs_file_aio_read

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 2/9] xfs: fix incorrect error sign in xfs_file_aio_read
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 13 May 2014 20:46:45 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1399971373-6242-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1399971373-6242-1-git-send-email-david@xxxxxxxxxxxxx> <1399971373-6242-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 05/13 2014 16:56 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index f499e47..37f98c6 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -295,7 +295,7 @@ xfs_file_aio_read(
>               xfs_rw_ilock(ip, XFS_IOLOCK_EXCL);
>  
>               if (inode->i_mapping->nrpages) {
> -                     ret = -filemap_write_and_wait_range(
> +                     ret = filemap_write_and_wait_range(
>                                                       VFS_I(ip)->i_mapping,
>                                                       pos, -1);
>                       if (ret) {
> 

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>


Cheers,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>