xfs
[Top] [All Lists]

Re: [PATCH 1/9] xfs: xfs_dir_fsync() returns positive errno

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/9] xfs: xfs_dir_fsync() returns positive errno
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 13 May 2014 20:46:08 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1399971373-6242-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1399971373-6242-1-git-send-email-david@xxxxxxxxxxxxx> <1399971373-6242-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 05/13 2014 16:56 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> And it should be negative.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 951a232..f499e47 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -155,7 +155,7 @@ xfs_dir_fsync(
>  
>       if (!lsn)
>               return 0;
> -     return _xfs_log_force_lsn(mp, lsn, XFS_LOG_SYNC, NULL);
> +     return -_xfs_log_force_lsn(mp, lsn, XFS_LOG_SYNC, NULL);
>  }
>  
>  STATIC int
> 

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>


Cheers,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>