Re: [PATCH 1/9] xfs: xfs_dir_fsync() returns positive errno

[Jeff Liu <jeff.liu@xxxxxxxxxx>]

On 05/13 2014 16:56 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> And it should be negative.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 951a232..f499e47 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -155,7 +155,7 @@ xfs_dir_fsync(
>  
>       if (!lsn)
>               return 0;
> -     return _xfs_log_force_lsn(mp, lsn, XFS_LOG_SYNC, NULL);
> +     return -_xfs_log_force_lsn(mp, lsn, XFS_LOG_SYNC, NULL);
>  }
>  
>  STATIC int
> 

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>


Cheers,
-Jeff