xfs
[Top] [All Lists]

[PATCH] xfstests: use killall -9 and wait in _cleanup() in xfs/013

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfstests: use killall -9 and wait in _cleanup() in xfs/013
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Tue, 13 May 2014 08:24:34 -0400
Delivered-to: xfs@xxxxxxxxxxx
Kill any lingering fsstress processes and wait properly should we abort
the test. This prevents the workload from inadvertently affecting
subsequent tests.

Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
---

Dave,

Sorry, this probably should have been posted sooner. I was half
expecting to have more changes to the test. Looks like you fixed up the
groups already (thanks), so here's a small one to fix up the exit
path... Obviously it's not the end of the world if this waits for the
next natural xfstests update. :)

Brian

 tests/xfs/013 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/xfs/013 b/tests/xfs/013
index 049f0dc..e95d027 100755
--- a/tests/xfs/013
+++ b/tests/xfs/013
@@ -40,7 +40,8 @@ status=1      # failure is the default!
 
 _cleanup()
 {
-       killall fsstress 2>/dev/null
+       killall -9 fsstress 2>/dev/null
+       wait
        cd /
        umount $SCRATCH_MNT 2>/dev/null
        rm -f $tmp.*
-- 
1.8.3.1

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfstests: use killall -9 and wait in _cleanup() in xfs/013, Brian Foster <=