xfs
[Top] [All Lists]

Re: [PATCH -v2] check: add support for an external file containing tests

To: Theodore Ts'o <tytso@xxxxxxx>
Subject: Re: [PATCH -v2] check: add support for an external file containing tests to exclude
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 13 May 2014 08:00:27 +1000
Cc: xfs@xxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140512124232.GB31376@xxxxxxxxx>
References: <20140416001530.GU15995@dastard> <1397624302-9577-1-git-send-email-tytso@xxxxxxx> <20140416064018.GJ15995@dastard> <20140512124232.GB31376@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, May 12, 2014 at 08:42:32AM -0400, Theodore Ts'o wrote:
> On Wed, Apr 16, 2014 at 04:40:18PM +1000, Dave Chinner wrote:
> > On Wed, Apr 16, 2014 at 12:58:22AM -0400, Theodore Ts'o wrote:
> > > Currently the -X option is intended to specify a set of expunging
> > > files which are stored in each test/* subdirectory.  As described in
> > > the commit description for 0b1e8abd4, in order to exclude the test
> > > generic/280, the -X option is used as follows:
> > > 
> > >     $ cat tests/generic/3.0-stable-avoid
> > >     280
> > >     $ sudo ./check -X 3.0-stable-avoid generic/280
> > > 
> > > However, it is sometimes useful to store the set of expunged tests in
> > > a single file, outside of tests/* subdirectories.  This commit enables
> > > the following:
> > > 
> > >     $ cat /root/conf/data_journal.exclude
> > >     generic/068
> > >     ext4/301
> > >     $ sudo ./check -E /root/conf/data_journal.exclude -g auto
> > > 
> > > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
> > 
> > Looks good.
> > 
> > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> This patch has apparently not hit the xfstests repository.  Would you
> like me to resend it?

No, I just haven't done an xfstests update for the past couple of
weeks because there haven't been a lot of patches and I've been busy
with other stuff. I'll do one later in the week.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>