xfs
[Top] [All Lists]

Re: 'delete' parameter in xfs_ialloc.h

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: 'delete' parameter in xfs_ialloc.h
From: Roger Willcocks <roger@xxxxxxxxxxxxxxxx>
Date: Mon, 12 May 2014 18:52:25 +0100
Cc: Roger Willcocks <roger@xxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5370E964.50805@xxxxxxxxxxx>
References: <1399908138.4857.28.camel@xxxxxxxxxxxxxxxxxxxxxxxx> <5370E964.50805@xxxxxxxxxxx>
On 12 May 2014, at 16:31, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:

> On 5/12/14, 10:22 AM, Roger Willcocks wrote:
>> Hi folks,
>> 
>> I have to fix this up every time I update xfsprogs -
>> 
>> The 'delete' parameter in xfsprogs/include/xfs_ialloc.c:xfs_difree(...)
>> causes a compile error if the header's included in C++ code (even with
>> 'extern "C"') -
>> 
>> xfs_ialloc.h:102: error: expected ‘,’ or ‘...’ before ‘delete’
>> 
>> (gcc 4.4.7)
>> 
>> It would be handy if the parameter name could be commented out or
>> changed in the header.
>> 
> 
> Send a patch?  Would need to hit kernel code too.
> 
> -Eric
> 

Okay, two near-identical patches, one for xfsprogs and one for xfs follow.

--
Roger

<Prev in Thread] Current Thread [Next in Thread>