xfs
[Top] [All Lists]

Re: [PATCH -v2] check: add support for an external file containing tests

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH -v2] check: add support for an external file containing tests to exclude
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Mon, 12 May 2014 08:42:32 -0400
Cc: xfs@xxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=KVxkYZr2mS4Jp20eBmmw884cNuz+VCudkf0TAPXvZEE=; b=KcdxSJ8fgffah8Eef5c5nGhO7WAhSWizlmLWzoqXh0V542boHpKVfMm2fXDNdzRkV//cvltHt+QY+P/sztEWfBpzryptZvwstQZAa2cederbzgqoaZd+nmPxOQ5kUq2A7lxNZJGqTTkFh/Ivopr+P17ofaf6bwHFnMuD2PTZqI8=;
In-reply-to: <20140416064018.GJ15995@dastard>
References: <20140416001530.GU15995@dastard> <1397624302-9577-1-git-send-email-tytso@xxxxxxx> <20140416064018.GJ15995@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Apr 16, 2014 at 04:40:18PM +1000, Dave Chinner wrote:
> On Wed, Apr 16, 2014 at 12:58:22AM -0400, Theodore Ts'o wrote:
> > Currently the -X option is intended to specify a set of expunging
> > files which are stored in each test/* subdirectory.  As described in
> > the commit description for 0b1e8abd4, in order to exclude the test
> > generic/280, the -X option is used as follows:
> > 
> >     $ cat tests/generic/3.0-stable-avoid
> >     280
> >     $ sudo ./check -X 3.0-stable-avoid generic/280
> > 
> > However, it is sometimes useful to store the set of expunged tests in
> > a single file, outside of tests/* subdirectories.  This commit enables
> > the following:
> > 
> >     $ cat /root/conf/data_journal.exclude
> >     generic/068
> >     ext4/301
> >     $ sudo ./check -E /root/conf/data_journal.exclude -g auto
> > 
> > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
> 
> Looks good.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

This patch has apparently not hit the xfstests repository.  Would you
like me to resend it?

Thanks,

                                                - Ted

<Prev in Thread] Current Thread [Next in Thread>