[Top] [All Lists]

Re: [PATCH] xfstests: filter out selinux xattrs for generic/062

To: Eric Sandeen <sandeen@xxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: filter out selinux xattrs for generic/062
From: Josef Bacik <jbacik@xxxxxx>
Date: Fri, 9 May 2014 16:20:54 -0400
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=G8nIDRaszUfvAYTNn5XXEpR/LYKSjoS5YXO88hr2Avs=; b=djWNmLZBo0+zVM6ZdqXYhGqfQWPTK/Lg9hOi4rlQSIY9Pc6+SW2aL5AnEibkU/8jhpi2 TyU8YAHss7T9zioOb2a76rsUVggvxNavQ0ByLxtRAew0lz1wduUBuGDgKo7DyYwlyzVP D54SGPb0oFzdx8p9kXPyNYeMpHE2K/KMDAI=
In-reply-to: <536D37F6.90603@xxxxxxxxxx>
References: <1399664668-719-1-git-send-email-jbacik@xxxxxx> <536D37F6.90603@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
On 05/09/2014 04:17 PM, Eric Sandeen wrote:
On 5/9/14, 2:44 PM, Josef Bacik wrote:
If you have selinux enabled getfattr will show the selinux xattrs, which screws
with the golden output of generic/062.  To make matters worse you can't just
greap it out because we'll still get the preamble and newline from getfattr when
the selinux attr is the only attr.  So this is the voodoo I came up with after
way more time than I'm comfortable admitting to make this test pass if you have
selinux enabled.  Thanks,

I thought that we were pretty much universally mounting with an selinux
context, rather than allowing selinux to add its own on-disk attrs.

Why is that not the case for this test?

Works for me on this old kernel anyway:

[root@bp-05 xfstests]# getenforce
[root@bp-05 xfstests]# ./check generic/062
FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/x86_64 bp-05 2.6.32
MKFS_OPTIONS  -- -f -bsize=4096 /dev/sdc2
MOUNT_OPTIONS -- -o context=system_u:object_r:nfs_t:s0 /dev/sdc2 /mnt/scratch

generic/062 60s ... 3s
Ran: generic/062
Passed all 1 tests

Note the mount options above...

I have MOUNT_OPTIONS set to something else so I lose the context bit. Thanks,


<Prev in Thread] Current Thread [Next in Thread>