[Top] [All Lists]

Re: [PATCH v3] xfstests/btrfs: add qgroup rescan stress test

To: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH v3] xfstests/btrfs: add qgroup rescan stress test
From: Josef Bacik <jbacik@xxxxxx>
Date: Fri, 9 May 2014 13:32:57 -0400
Cc: <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=D48ku3TpDSWTF4OtWXvKO6jE2oxQvx3NdB5+bkPGQX0=; b=pyKoAbEzFcbDae8pl3QUJTW81KpBglz+AorkJPaZVc2RxeV9yXshrvZCIYePFU3cTKmx k1hRyTXjRqYIr1cdua43OFfvqwYl45YmA+1lYOLaaJv5jjkhzoaoGGNE9nVIt9YodG5w s28iTfcZ7/uAu4kA7DRIyhBW6MgCN8t129U=
In-reply-to: <1399615343-28544-1-git-send-email-wangsl.fnst@xxxxxxxxxxxxxx>
References: <1394423051-17356-1-git-send-email-wangsl.fnst@xxxxxxxxxxxxxx> <1399615343-28544-1-git-send-email-wangsl.fnst@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
On 05/09/2014 02:02 AM, Wang Shilong wrote:
Test flow is to run fsstress after triggering quota rescan.
the ruler is simple, we just remove all files and directories,
sync filesystem and see if qgroup's ref and excl are nodesize.

Signed-off-by: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>
v2->v3: addressed comments from josef:
        - remove unnecessary redirections
        - don't use _run_btrfs_util_prog() when capturing qgroup show output.
        - turn off inode_cache mount option explicitly.

v1->v2: switch to _run_btrfs_util_prog()

Perfect thanks Wang,

Reviewed-by: Josef Bacik <jbacik@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>