[Top] [All Lists]

Re: Remove xfs_check for 3.2.0?

To: Emmanuel Florac <eflorac@xxxxxxxxxxxxxx>
Subject: Re: Remove xfs_check for 3.2.0?
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 9 May 2014 08:02:14 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140508230410.02b19431@xxxxxxxxxxxxxx>
References: <536BCF95.201@xxxxxxxxxxx> <20140508203936.GV5421@dastard> <536BEBD9.4060604@xxxxxxxxxxx> <20140508230410.02b19431@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, May 08, 2014 at 11:04:10PM +0200, Emmanuel Florac wrote:
> Le Thu, 08 May 2014 15:40:57 -0500 vous écriviez:
> > *shrug* ok.  Let a thousand "hey my xfs_check OOM'd" emails
> > blossom! :)
> > 
> > FWIW, I did not have time to work on that prefetch bug yet today.  :(
> > 
> Why not replace it by a script that simply states that it's useless and
> to run xfs_repair -n instead? It has been completely useless for the
> best part of the past ten years... This way you don't remove it but
> you'll sort of fix it :)

xfs_check is already just a script that wraps xfs_db.

However, there's all the man page updates, all the external
documentation needs to be updated, etc. IOWs, it's not just a case
of a simply patching out the xfs_check script....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>