[Top] [All Lists]

Re: [PATCH 3/5] xfs: turn NLINK feature on by default

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: turn NLINK feature on by default
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 19:06:36 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140506081518.GB24143@xxxxxxxxxxxxx>
References: <1399348559-19889-1-git-send-email-david@xxxxxxxxxxxxx> <1399348559-19889-4-git-send-email-david@xxxxxxxxxxxxx> <20140506081518.GB24143@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 06, 2014 at 01:15:18AM -0700, Christoph Hellwig wrote:
> >  
> > @@ -1112,7 +1085,7 @@ xfs_bumplink(
> >              * system to do this, then we need to bump the superblock
> >              * version number as well.
> >              */
> > -           xfs_bump_ino_vers2(tp, ip);
> > +           xfs_bump_ino_vers2(ip);
> The comment here is certainly out of date now.
> But I think keeping these xfs_bump_ino_vers2 calls around everywhere is
> wrong to start with.  xfs_iread should make sure all inodes are version
> 1, that allows to kill xfs_bump_ino_vers2 entirely, and probably also
> simplify xfs_ialloc a little more.  At the point we won't have to deal
> with v1 inodes anywhere but in xfs_iread, and we can have a big fat
> comment in that place why we even bother with the v1 inodes, because
> the fact that we have the hasnlink bit but inodes might still be old
> format is something we'll all have forgotten about in a few years,
> and new developers will never figure out by themselves.

OK, I'll look at reworking it aong those lines.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>