[Top] [All Lists]

Re: [PATCH 4/5] xfs: don't need dirv2 checks anymore

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfs: don't need dirv2 checks anymore
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 18:45:05 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140506081652.GC24143@xxxxxxxxxxxxx>
References: <1399348559-19889-1-git-send-email-david@xxxxxxxxxxxxx> <1399348559-19889-5-git-send-email-david@xxxxxxxxxxxxx> <20140506081652.GC24143@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 06, 2014 at 01:16:52AM -0700, Christoph Hellwig wrote:
> > -   ASSERT(xfs_sb_version_hasdirv2(&mp->m_sb));
> > +   ASSERT(mp->m_sb.sb_versionnum & XFS_SB_VERSION_DIRV2BIT);
> How is this going to work for v5 filesystems?  Probably better to just
> kill the assert..

mkfs still sets the sb_features bitmask for all the supported v4
features it uses by default on v5 superblocks. There are some
feature bits in the v4 mask that are optional for v5 superblocks,
too (e.g. case insensitivity, sunit/swidth alignment), so we won't
ever stop setting the XFS_SB_VERSION_DIRV2BIT on v5 superblocks...

> Otherwise looks good,
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>



Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>