[Top] [All Lists]

Re: [RFC] libxfs kernel infrastructure (was [XFS updates] XFS developmen

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8)
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 01:37:44 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140506075905.GA5421@dastard>
References: <20140506071855.F152E7FBC@xxxxxxxxxxx> <20140506075905.GA5421@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
I like this in general, but one major and one minor issue with
the include files:

 - headers that just include other headers are a bad idea in general.
   Either they are dependent enough that they should be merged, or
   they are not, in which case they shouldn't.

   In this case it seems like we should temporarily provide a
   xfs_mount.h stub in userspace, and just leave all the includes
   for things in libxfs.h as they were.  That doesn't preclude further
   merging of the headers into more sensible ones as we've started
   with the disk formats.
 - do we really need the separate include/ dir?  That always annoys
   me when editing code.  It makes sense for something that is a real
   public interface, which this is not.

Also is libxfs/ really the right name?  libxfs in userspace has quite
a bit more code than this, so maybe we should just called this "shared"
for the shared user/kernel code?

<Prev in Thread] Current Thread [Next in Thread>