xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs: don't need dirv2 checks anymore

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfs: don't need dirv2 checks anymore
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 01:16:52 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1399348559-19889-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1399348559-19889-1-git-send-email-david@xxxxxxxxxxxxx> <1399348559-19889-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> -     ASSERT(xfs_sb_version_hasdirv2(&mp->m_sb));
> +     ASSERT(mp->m_sb.sb_versionnum & XFS_SB_VERSION_DIRV2BIT);

How is this going to work for v5 filesystems?  Probably better to just
kill the assert..

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>