xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix directory readahead offset off-by-one

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix directory readahead offset off-by-one
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 00:56:37 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1399347728-19752-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1399347728-19752-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 06, 2014 at 01:42:08PM +1000, Dave Chinner wrote:
> Fix the warning by ensuring that the readahead offset is correctly
> incremented.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_dir2_readdir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_dir2_readdir.c b/fs/xfs/xfs_dir2_readdir.c
> index 50b72f7..fe2db98 100644
> --- a/fs/xfs/xfs_dir2_readdir.c
> +++ b/fs/xfs/xfs_dir2_readdir.c
> @@ -456,7 +456,7 @@ xfs_dir2_leaf_readbuf(
>               /*
>                * Advance offset through the mapping table.
>                */
> -             for (j = 0; j < mp->m_dirblkfsbs; j++) {
> +             for (j = 0; j < mp->m_dirblkfsbs; ) {
>                       /*
>                        * The rest of this extent but not more than a dir
>                        * block.

This looks correct, but it would seem a little more idiomatic to write
this as:

                for (j = 0; j < mp->m_dirblkfsbs; j += length) {

and remove the j increment from the body.

<Prev in Thread] Current Thread [Next in Thread>