xfs
[Top] [All Lists]

Re: [PATCH 6/6] use xfs_icluster_size_fsb in xfs_imap

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH 6/6] use xfs_icluster_size_fsb in xfs_imap
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 5 May 2014 17:10:39 -0400
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <536784DF.5040509@xxxxxxxxxx>
References: <536784DF.5040509@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, May 05, 2014 at 08:32:31PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Use xfs_icluster_size_fsb() in xfs_imap().
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  libxfs/xfs_ialloc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
> index 7d2ae8d..c8967db 100644
> --- a/libxfs/xfs_ialloc.c
> +++ b/libxfs/xfs_ialloc.c
> @@ -1353,7 +1353,7 @@ xfs_imap(
>               return XFS_ERROR(EINVAL);
>       }
>  
> -     blks_per_cluster = mp->m_inode_cluster_size >> mp->m_sb.sb_blocklog;
> +     blks_per_cluster = xfs_icluster_size_fsb(mp);
>  
>       /*
>        * For bulkstat and handle lookups, we have an untrusted inode number
> @@ -1374,7 +1374,7 @@ xfs_imap(
>        * If the inode cluster size is the same as the blocksize or
>        * smaller we get to the buffer by simple arithmetics.
>        */
> -     if (mp->m_inode_cluster_size <= mp->m_sb.sb_blocksize) {
> +     if (blks_per_cluster == 1) {
>               offset = XFS_INO_TO_OFFSET(mp, ino);
>               ASSERT(offset < mp->m_sb.sb_inopblock);
>  
> -- 
> 1.8.3.2
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>