xfs
[Top] [All Lists]

Re: [PATCH 0/5] xfstests: fixes for the free inode btree

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 0/5] xfstests: fixes for the free inode btree
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 3 May 2014 09:48:31 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1399050842-19633-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1399050842-19633-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, May 02, 2014 at 01:13:57PM -0400, Brian Foster wrote:
> Hi all,
> 
> This series is a few xfstests fixes and addons for the finobt. Patch 1
> fixes xfs/030 to work correctly on finobt-enabled filesystems. Patches 2
> and 3 add support for finobt-oriented tests via require functions and
> repair filter updates. Patch 4 adds a new test for targeted repair of
> finobt filesystems. Patch 5 adds a stress test that creates/modifies a
> sparsely allocated set of inodes to effectively exercise the finobt in
> conjunction with an fsstress workload.
> 
> xfs/010 runs very quickly. xfs/013 runs for 5-10 minutes on my smallish
> VM running against a single spindle, so I've been back and forth on
> whether it should be part of the auto group. Thoughts, reviews, flames
> appreciated...

5-10 minutes is probably right at the edge for auto, but I think
that most people won't be testing this any time soon. Hence I'd
include it by default in the auto group, and if people complain
about the runtime when they start testing it, we can revist that
choice. FWIW, I'd also include it in the metadata group so that it
gets exercised when people run that group....

I had a quick eyeball of the changes, and nothing major stood out.
The only thing I noticed was a missing "wait" in the _cleanup
function of xfs/013 after killing all the fsstress processes. It
should probably using killall -9 as well. If we don't wait, then the
unmount will fail and if the fsstress processes don't die it will
affect every test after that...

I'll probably have more suggestions once I've run the tests ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>