xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 30 Apr 2014 08:10:21 -0700
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53610D16.9040609@xxxxxxxxxxx>
References: <20140430134844.924376330@xxxxxxx> <20140430135319.660238697@xxxxxxx> <53610D16.9040609@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 30, 2014 at 09:47:50AM -0500, Eric Sandeen wrote:
> On 4/30/14, 8:48 AM, Mark Tinguely wrote:
> > Remove the unused second argument to xfs_iput() and
> > xfs_trans_iput().
> > 
> > Introduce the define "IRELE()" and use in place of xfs_iput().
> 
> Why do this?  We had been moving away from the upper-case-macro-
> redefined-to-a-function meme... what does this #define gain?
> 
> libxfs_iget/libxfs_iput pairs seem more obvious than
> libxfs_iget/IRELE()...

Mostly to match the kernel that makes it do an iput underneath..

<Prev in Thread] Current Thread [Next in Thread>