xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 30 Apr 2014 10:02:52 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53610DA7.8070806@xxxxxxx>
References: <20140430134844.924376330@xxxxxxx> <20140430135319.660238697@xxxxxxx> <53610D16.9040609@xxxxxxxxxxx> <53610DA7.8070806@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 4/30/14, 9:50 AM, Mark Tinguely wrote:
> On 04/30/14 09:47, Eric Sandeen wrote:
>> On 4/30/14, 8:48 AM, Mark Tinguely wrote:
>>> >  Remove the unused second argument to xfs_iput() and
>>> >  xfs_trans_iput().
>>> >
>>> >  Introduce the define "IRELE()" and use in place of xfs_iput().
>> Why do this?  We had been moving away from the upper-case-macro-
>> redefined-to-a-function meme... what does this #define gain?
>>
>> libxfs_iget/libxfs_iput pairs seem more obvious than
>> libxfs_iget/IRELE()...
>>
>> Thanks,
>> -Eric
>>
> 
> To be consistent with the kernel code.

Gah, hohum, I'm not even going to try to explain why I thought
we didn't have it in kernel code.

sorry for the noise,
-Eric

> --Mark.
> 

<Prev in Thread] Current Thread [Next in Thread>