| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Wed, 30 Apr 2014 09:50:15 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <53610D16.9040609@xxxxxxxxxxx> |
| References: | <20140430134844.924376330@xxxxxxx> <20140430135319.660238697@xxxxxxx> <53610D16.9040609@xxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 04/30/14 09:47, Eric Sandeen wrote: On 4/30/14, 8:48 AM, Mark Tinguely wrote:> Remove the unused second argument to xfs_iput() and > xfs_trans_iput(). > > Introduce the define "IRELE()" and use in place of xfs_iput().Why do this? We had been moving away from the upper-case-macro- redefined-to-a-function meme... what does this #define gain? libxfs_iget/libxfs_iput pairs seem more obvious than libxfs_iget/IRELE()... Thanks, -Eric To be consistent with the kernel code. --Mark. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput, Eric Sandeen |
| Next by Thread: | Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |