xfs
[Top] [All Lists]

[PATCH v2] xfstests: fsstress: fix incorrect if condition check for coll

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: [PATCH v2] xfstests: fsstress: fix incorrect if condition check for collapse range mode
From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
Date: Wed, 30 Apr 2014 19:35:11 +0900
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Lukáš Czerner <lczerner@xxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dlp-filter: Pass
Thread-index: Ac9kX1garIi4UQ2rSXyzysmHwZv4dg==
There is if condition to be block aligned for off and len of Collapse range.
But off and len for all fallocate opearion can be aligned by incorrect
if condition check.

Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
Signed-off-by: Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx>
---
 ltp/fsstress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 29fc250..ff9ed12 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -2230,7 +2230,7 @@ do_fallocate(int opno, long r, int mode)
         * Collapse range requires off and len to be block aligned, make it
         * more likely to be the case.
         */
-       if (FALLOC_FL_COLLAPSE_RANGE && (opno % 2)) {
+       if ((mode & FALLOC_FL_COLLAPSE_RANGE) && (opno % 2)) {
                off = ((off + stb.st_blksize - 1) & ~(stb.st_blksize - 1));
                len = ((len + stb.st_blksize - 1) & ~(stb.st_blksize - 1));
        }
-- 
1.7.11-rc0

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH v2] xfstests: fsstress: fix incorrect if condition check for collapse range mode, Namjae Jeon <=