Re: [PATCH 5/9] repair: detect CRC errors in AG headers

xfs

Re: [PATCH 5/9] repair: detect CRC errors in AG headers

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 5/9] repair: detect CRC errors in AG headers
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 29 Apr 2014 11:16:56 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1398719099-19194-6-git-send-email-david@xxxxxxxxxxxxx>
References:	<1398719099-19194-1-git-send-email-david@xxxxxxxxxxxxx> <1398719099-19194-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Apr 29, 2014 at 07:04:55AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> repair doesn't currently detect verifier errors in AG header
> blocks - apart from the primary superblock they are not detected.
> They are, fortunately, corrected in the important cases (AGF, AGI
> and AGFL) because these structures are rebuilt in phase 5, but if
> you run xfs_repair in checking mode it won't report them as bad.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/9 v3] xfs_db, xfs_repair: improve CRC error detection, Dave Chinner [PATCH 2/9] db: verify buffer on type change, Dave Chinner [PATCH 5/9] repair: detect CRC errors in AG headers, Dave Chinner Re: [PATCH 5/9] repair: detect CRC errors in AG headers, Brian Foster Re: [PATCH 5/9] repair: detect CRC errors in AG headers, Christoph Hellwig <= [PATCH 6/9] repair: report AG btree verifier errors, Dave Chinner [PATCH 4/9] repair: detect and correct CRC errors in directory blocks, Dave Chinner [PATCH 1/9] db: don't claim unchecked CRCs are correct, Dave Chinner [PATCH 9/9] repair: detect and handle attribute tree CRC errors, Dave Chinner Re: [PATCH 9/9] repair: detect and handle attribute tree CRC errors, Brian Foster Re: [PATCH 9/9] repair: detect and handle attribute tree CRC errors, Dave Chinner Re: [PATCH 9/9] repair: detect and handle attribute tree CRC errors, Christoph Hellwig [PATCH 8/9] repair: handle remote symlink CRC errors, Dave Chinner Re: [PATCH 8/9] repair: handle remote symlink CRC errors, Brian Foster Re: [PATCH 8/9] repair: handle remote symlink CRC errors, Christoph Hellwig

Previous by Date:	Re: [PATCH 3/9] repair: ensure prefetched buffers have CRCs validated, Christoph Hellwig
Next by Date:	Re: [PATCH 8/9] repair: handle remote symlink CRC errors, Christoph Hellwig
Previous by Thread:	Re: [PATCH 5/9] repair: detect CRC errors in AG headers, Brian Foster
Next by Thread:	[PATCH 6/9] repair: report AG btree verifier errors, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]