xfs
[Top] [All Lists]

Re: [PATCH] xfs: test for shut down fs in xfs_dir_fsync()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: test for shut down fs in xfs_dir_fsync()
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Mon, 28 Apr 2014 12:18:31 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Boris Ranto <branto@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140428164754.GA17472@xxxxxxxxxxxxx>
References: <535E8344.2070209@xxxxxxxxxx> <20140428164754.GA17472@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 4/28/14, 11:47 AM, Christoph Hellwig wrote:
> On Mon, Apr 28, 2014 at 11:35:16AM -0500, Eric Sandeen wrote:
>> Similar to xfs_file_fsync(), I think xfs_dir_fsync() needs
>> to test for a shut down fs,
> 
> It probably should.
> 
>> lest we go down paths we'll
>> never be able to complete; Boris reported that during some
>> stress tests he had threads stuck in xlog_cil_force_lsn
>> via xfs_dir_fsync().
> 
> But this could still happen if we get a shutdown coming in after that
> test.

True... that looked a bit hairier to sort out.  :(

-Eric

<Prev in Thread] Current Thread [Next in Thread>