xfs
[Top] [All Lists]

Re: [PATCH] xfstests: introduce FSX_AVOID env var

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: introduce FSX_AVOID env var
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 25 Apr 2014 08:57:52 -0500
Cc: ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140425063153.GC27527@xxxxxxxxxxxxx>
References: <5355478C.8070905@xxxxxxxxxx> <20140425063153.GC27527@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 4/25/14, 1:31 AM, Christoph Hellwig wrote:
> On Mon, Apr 21, 2014 at 11:30:04AM -0500, Eric Sandeen wrote:
>> Just like FSSTRESS_AVOID, FSX_AVOID can be used to add
>> options at the end of the default fsx runs in each test.
>> i.e. FSX_AVOID="-H -z -C" will disable punch hole, zero range,
>> and collapse range calls in all tests which run fsx.
>>
>> This should handle Ted's concerns about buggy ext4 fallocate
>> code without needing to add tunables to the kernel to reject
>> these operations during xfstests runs.
> 
> I would much prefer to add a little _run_fsx helper to encapsulate this.
> 

Dave already merged it, but yeah, that's a good idea, for fsx
as well as fsstress.

-Eric

<Prev in Thread] Current Thread [Next in Thread>