xfs
[Top] [All Lists]

Re: [RFC] libxfs: adding attribute fork frees xfs_inode ptr

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [RFC] libxfs: adding attribute fork frees xfs_inode ptr
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 25 Apr 2014 08:18:11 -0500
Cc: XFS Mailing List <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140425054021.GA16132@xxxxxxxxxxxxx>
References: <20140423210034.892939354@xxxxxxx> <20140423210445.700477624@xxxxxxx> <20140423222215.GT18672@dastard> <535945DC.6010108@xxxxxxx> <53597B34.9050407@xxxxxxx> <20140425054021.GA16132@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/25/14 00:40, Christoph Hellwig wrote:
On Thu, Apr 24, 2014 at 03:59:32PM -0500, Mark Tinguely wrote:
PS. I may not have been very clear, the libxfs_trans_roll() and
     inode_item_done() also cause a premature libxfs_iput().
     Let me do more testing making any changes and target this for
     xfsprogs-3.2.1.

You mean you've fixed the way we handle the attachement of inodes to
transaction in userspace to mirror what we do in kernelspace?  I'd love
to review this if you have patches as it's a somewhat of a pain point
to have these work so different in kernel and userspace.


Not yet, I made the changes within the existing code so I can continue with my project. I agree, the user inode transaction code has to be synced with the kernel. I will start looking at it this weekend.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>