xfs
[Top] [All Lists]

Re: [PATCH v2 10/10] xfs: isolate xfs_qm_quotacheck to its source file

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 10/10] xfs: isolate xfs_qm_quotacheck to its source file
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Fri, 25 Apr 2014 16:05:36 +0800
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140425065545.GE20871@xxxxxxxxxxxxx>
References: <535078D4.4000802@xxxxxxxxxx> <20140425065545.GE20871@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 04/25 2014 14:55 PM, Christoph Hellwig wrote:
> On Fri, Apr 18, 2014 at 08:59:00AM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>>
>> Isolate xfs_qm_quotacheck() to xfs_qm.c as there is no other users of it.
>>
>> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Looks good, but the description is a bit confusing, we'd normallay say
> something like:
> 
> "xfs: mark xfs_qm_quotacheck as static
> 
> xfs_qm_quotacheck is not used outside of xfs_qm.c.  Mark it static and
> move it around in the file to avoid a forward declaration."

Nice suggestion, thanks for your review.


Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>