xfs
[Top] [All Lists]

Re: [PATCH v2 04/10] xfs: introduce per allocation group inumbers

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 04/10] xfs: introduce per allocation group inumbers
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Fri, 25 Apr 2014 15:14:14 +0800
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140425064333.GA20871@xxxxxxxxxxxxx>
References: <535078B5.4010700@xxxxxxxxxx> <20140425064333.GA20871@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 04/25 2014 14:43 PM, Christoph Hellwig wrote:
> On Fri, Apr 18, 2014 at 08:58:29AM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>>
>> Introduce xfs_perag_inumbers(), it could be used to fetch the inode number
>> tables per allocation group via a new ioctl(2) in the future.  Also, that
>> would be a net win considering the scalability for a file system with huge
>> number of inodes as multiple allocation groups can be scanned in parallel,
>> refactor xfs_inumbers() with it.
> 
> Given that you don't actually introduce a per-ag inumbers interface in
> this series I'd prefer if you just refactor the inumbers code to
> add a helper that operates on an AG with xfs_inumbers moving on to
> the next one, but not adding the xfs_aginumbers structure that just
> makes the move less obvious for now. 

Fair enough, I'll take care of it.


Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>