xfs
[Top] [All Lists]

Re: [PATCH v2 10/10] xfs: isolate xfs_qm_quotacheck to its source file

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v2 10/10] xfs: isolate xfs_qm_quotacheck to its source file
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 24 Apr 2014 23:55:45 -0700
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <535078D4.4000802@xxxxxxxxxx>
References: <535078D4.4000802@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Apr 18, 2014 at 08:59:00AM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Isolate xfs_qm_quotacheck() to xfs_qm.c as there is no other users of it.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Looks good, but the description is a bit confusing, we'd normallay say
something like:

"xfs: mark xfs_qm_quotacheck as static

xfs_qm_quotacheck is not used outside of xfs_qm.c.  Mark it static and
move it around in the file to avoid a forward declaration."

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>