Re: [PATCH v2 10/10] xfs: isolate xfs_qm_quotacheck to its source file

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Fri, Apr 18, 2014 at 08:59:00AM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Isolate xfs_qm_quotacheck() to xfs_qm.c as there is no other users of it.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Looks good, but the description is a bit confusing, we'd normallay say
something like:

"xfs: mark xfs_qm_quotacheck as static

xfs_qm_quotacheck is not used outside of xfs_qm.c.  Mark it static and
move it around in the file to avoid a forward declaration."

Reviewed-by: Christoph Hellwig <hch@xxxxxx>